Re: [PATCH v4 1/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2017, 03:25 UTC
Message-ID: <xmqq1sklk9gy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqd145k9td.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

>  - 5/6: What we see in [v4 1/6] (except for introduction of the
>         helper, which already happened in an earlier step).  Move
>         the promise of covering this new output format with a follow
>         up series to the proposed log message of this step from [v4
>         6/6].
>
>  - 6/6: Realize the promise made in 5/6.
> ...
> For rererence, here is what I just whipped up that would come in
> between the steps 4/6 and 5/6 in the above outline (i.e. split from
> 6/6 to be placed before 5/6 happens).

Just to be sure, I wrote this on top of [v4 1-6/6], so you'd see that its preimage already knows about GIT_PRINT_SHA1_ELLIPSIS=yes. In a real reroll of the series that follow the above reorganized structure, of course that would not appear as "-" line in the patch ;-)

Thanks.