Re: [PATCH v2 3/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

From: Ann T Ropea <bedhanger@gmx.de>
Date: Nov 19, 2017, 17:38 UTC
Message-ID: <20171119173838.8820-1-bedhanger@gmx.de>
In-Reply-To: <xmqq1sl17e1u.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> HOWEVER.

Show 9 quoted lines

> Notice the name of the function.  We no longer even attempt to align
> the output, and in general the output column length of each line
> would be shorter than the original.  I am wondering if the change
> would be of less impact if we try to abbreviate to len+3 and then
> chomp the result at the right hand side to len+3 (only if the result
> is unique) when print_sha1_ellipsis is false.  Of course, once we go
> that path, the code structure this patch introduces (not the one I
> mentioned in the previous paragraph) would be necessary.  Essentially
> you would be enhancing the "else" clause.

Sorry, but you've lost me there.

I'm in the process of producing v3 of the series (env var instead of config, comments, indentation level), but i can't get my head around the above.

Would you care to elaborate (then based on v3)?