Re: [PATCH] diffcore: add a filter to find a specific blob

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 12, 2017, 18:36 UTC
Message-ID: <xmqqpo7j3i9x.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171212012422.123332-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

> Sometimes users are given a hash of an object and they want to
> identify it further (ex.: Use verify-pack to find the largest blobs,
> but what are these? or [1])
> ...
>  Documentation/diff-options.txt |  6 ++++
>  Makefile                       |  1 +
>  builtin/log.c                  |  2 +-
>  diff.c                         | 20 ++++++++++++-
>  diff.h                         |  3 ++
>  diffcore-objfind.c             | 42 ++++++++++++++++++++++++++
>  diffcore.h                     |  1 +
>  revision.c                     |  5 +++-
>  t/t4064-diff-oidfind.sh        | 68 ++++++++++++++++++++++++++++++++++++++++++
>  9 files changed, 145 insertions(+), 3 deletions(-)
>  create mode 100644 diffcore-objfind.c
>  create mode 100755 t/t4064-diff-oidfind.sh

Thanks.  Will drop an asdf and queue.

I think this is ready for 'next'; I'll wait for a day or two just to give us a final chance to spot and save us from minor embarrassments, but I expect anything we'd spot from here on would be so minor that we can go incremental.