Re: [PATCH 1/1] diffcore: add a filter to find a specific blob

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Dec 8, 2017, 16:28 UTC
Message-ID: <643e1afd-43e2-7fcc-452b-8b9ceac6868c@ramsayjones.plus.com>
In-Reply-To: <20171208093434.GD26199@sigill.intra.peff.net>

On 08/12/17 09:34, Jeff King wrote:

> On Thu, Dec 07, 2017 at 04:24:47PM -0800, Stefan Beller wrote:

[snip]

Show 11 quoted lines

>> Junio hinted at a different approach of solving this problem, which this
>> patch implements. Teach the diff machinery another flag for restricting
>> the information to what is shown. For example:
>>
>>   $ ./git log --oneline --blobfind=v2.0.0:Makefile
>>   b2feb64309 Revert the whole "ask curl-config" topic for now
>>   47fbfded53 i18n: only extract comments marked with "TRANSLATORS:"
>>
>> we observe that the Makefile as shipped with 2.0 was introduced in
>> v1.9.2-471-g47fbfded53 and replaced in v2.0.0-rc1-5-gb2feb64309 by
>> a different blob.

Sorry, this has nothing to do with this specific thread. :(

However, the above caught my eye. Commit b2feb64309 does not 'replace the Makefile with a different blob'. That commit was a 'last minute' revert of a topic _prior_ to v2.0.0, which resulted in the _same_ blob as commit 47fbfded53. (i.e. a53f3a8326c2e62dc79bae7169d64137ac3dab20).

[I haven't been following this topic, so just ignore me if I have misunderstood what the above was describing! :-D ]

ATB, Ramsay Jones