Re: [PATCH] diffcore: add a filter to find a specific blob

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2017, 02:18 UTC
Message-ID: <xmqq374cspgw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171214225200.GA44616@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

>> Regarding finding a better name, I would want to hear from others,
>> I am happy with --find-object, though I can see --pickaxe-object
>> or --object--filter to be a good narrative as well.
>
> Drat, I was hoping for an opinion.

I think it would make it a better companion to --pickaxe but we need to align its behaviour a little bit so that it plays better with the "--pickaxe-all" option, and also needs to hide mode and name only changes just like pickaxe.

After all, the diffcore-blobfind code was written while looking at the diffcore-pickaxe's code in another window shown in the pager, and I tend to agree with your earlier message that this is an extreme case of -S<contents> where the contents happens to be the whole file.