Re: [PATCH 2/2] t3430: update to test with custom commentChar

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 9, 2018, 20:05 UTC
Message-ID: <xmqqpnzwcgyi.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <13a876a2-7fbc-de05-2e82-814c782e8a80@living180.net>

Daniel Harding <dharding@living180.net> writes:

Show 5 quoted lines

> One question about my original patch - there I had replaced a "grep
> -v" call with a "git stripspace" call in the 'generate correct todo
> list' test.  Is relying on "git stripspace" in a test acceptable, or
> should external text manipulation tools like grep, sed etc. be
> preferred?

I think trusting stripspace is OK here. Even though this test is not about stripspace (i.e. trying to catch breakage in stripspace), if we broke it, we'll notice it as a side effect of running this test ;-).