Re: [PATCH v3] sequencer: use configured comment character

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 16, 2018, 15:59 UTC
Message-ID: <nycvar.QRO.7.76.6.1807161758560.71@tvgsbejvaqbjf.bet>
In-Reply-To: <20180716045902.16629-1-aaron@schrab.com>

Hi Aaron,

On Mon, 16 Jul 2018, Aaron Schrab wrote:

Show 22 quoted lines

> At 10:15 -0700 12 Jul 2018, Junio C Hamano <gitster@pobox.com> wrote:
> >Aaron Schrab <aaron@schrab.com> writes:
> >> Note that the comment_line_char has already been resolved by this point,
> >> even if the user has configured the comment character to be selected
> >> automatically.
> >
> >Isn't this a slight lie?
> 
> Looking into that a bit further, it does seem like my explanation above 
> was incorrect.  Here's another attempt to explain why setting 
> core.commentChar=auto isn't a problem for this change.
> 
> 8< -----
> 
> Use the configured comment character when generating comments about
> branches in a todo list.  Failure to honor this configuration causes a
> failure to parse the resulting todo list.
> 
> Setting core.commentChar to "auto" will not be honored here, and the
> previously configured or default value will be used instead. But, since
> the todo list will consist of only generated content, there should not
> be any non-comment lines beginning with that character.

How about this instead?

	If core.commentChar is set to "auto", the intention is to
	determine the comment line character from whatever content is there
	already.

	As the code path in question is the one *generating* the todo list
	from scratch, it will automatically use whatever core.commentChar
	has been configured before the "auto" (and fall back to "#" if none
	has been configured explicitly), which is consistent with users'
	expectations.

Ciao, Johannes