Re: [PATCH 2/2] t3430: update to test with custom commentChar

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 9, 2018, 19:09 UTC
Message-ID: <nycvar.QRO.7.76.6.1807092107260.75@tvgsbejvaqbjf.bet>
In-Reply-To: <13a876a2-7fbc-de05-2e82-814c782e8a80@living180.net>

Hi Daniel,

On Mon, 9 Jul 2018, Daniel Harding wrote:

> One question about my original patch - there I had replaced a "grep -v"
> call with a "git stripspace" call in the 'generate correct todo list'
> test.  Is relying on "git stripspace" in a test acceptable, or should
> external text manipulation tools like grep, sed etc. be preferred?

I personally have no strong preference there; I tend to trust the "portability" of Git's tools more than the idiosyncrasies of whatever `grep` any setup happens to sport. But I am relatively certain that it is the exact opposite for, say, Junio (Git's maintainer), so...

Ciao, Johannes