Re: [PATCH v2 2/3] transport.c: introduce core.alternateRefsCommand
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2018, 22:23 UTC
- Message-ID
- <xmqqpnx6trpv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180921221317.GB11177@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 24 quoted lines
> On Fri, Sep 21, 2018 at 02:09:08PM -0700, Junio C Hamano wrote: > >> > +test_expect_success 'setup' ' >> > + test_commit one && >> > + git update-ref refs/heads/a HEAD && >> > + test_commit two && >> > + git update-ref refs/heads/b HEAD && >> > + test_commit three && >> > + git update-ref refs/heads/c HEAD && >> > + git clone --bare . fork && >> > + git clone fork pusher && >> > + ( >> > + cd fork && >> > + git config receive.advertisealternates true && >> >> Hmph. Do we have code to support this configuration variable? > > Sorry, I should have caught that. Our existing solution is to disable > alternates in the advertisement entirely (since the optimization > backfires for us). So this line is a leftover from testing it against > our fork, and should be dropped. > > If anybody is interested, we can share those patches, though they're > unsurprisingly trivial.
Heh, I guessed correctly what is going on ;-)
Even though there may not be much interest in the "all-or-none" boolean configuration, in order to upstream this custom thing, it may be the cleanest to upstream that all-or-none thing as well. Otherwise, you'd need to keep a patch to this test script that is private for your "all-or-none" feature. That's your maintenance burden so it ultimately is your call ;-)
> Also, useless-use-of-cat in the original, which could be: > > git update-ref --stdin <<-\EOF
Yup.
Thanks.