Re: [PATCH v3 1/4] transport: drop refnames from for_each_alternate_ref

From: Jeff King <peff@peff.net>
Date: Sep 28, 2018, 04:58 UTC
Message-ID: <20180928045858.GA25850@sigill.intra.peff.net>
In-Reply-To: <037273dab0f861e5f10241de1e32cddaabeab0cc.1538108385.git.me@ttaylorr.com>

> From: Jeff King <me@ttaylorr.com>

Pretty sure that isn't right. :)

The preferred way to send a patch with a different author is to have actual email be "From:" you, but then include a:

  From: Jeff King <peff@peff.net>

as the first line of the body (which git-am will then pick up). git-send-email will do this for you automatically. Other scripts (like say, if you're sending the output of format-patch into mutt) used to have to implement it themselves, but these days we have "format-patch --from", which should directly output what you want.

Show 6 quoted lines

> ---
>  builtin/receive-pack.c | 3 +--
>  fetch-pack.c           | 3 +--
>  transport.c            | 6 +++---
>  transport.h            | 2 +-
>  4 files changed, 6 insertions(+), 8 deletions(-)

The patch itself is flawless, of course. ;)

-Peff