Re: [PATCH 2/3] t9810: drop debug `cat` call
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 24, 2020, 19:18 UTC
- Message-ID
- <xmqqpne3pzey.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <ef45c9cabe7fe3f31d63edb872ba946ffbd951fe.1582447606.git.martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 10 quoted lines
> We `cat` kwdelfile.c, but don't inspect or grab the contents in any way. > This looks like a remnant from a debug session. Similar to the previous > commit, one could argue that `cat`-ing the file verifies that it didn't > disappear somehow. But because the very next thing we do after `cat`-ing > the file is to `grep` in it, we can safely drop the call to `cat`. > > Signed-off-by: Martin Ågren <martin.agren@gmail.com> > --- > t/t9810-git-p4-rcs.sh | 1 - > 1 file changed, 1 deletion(-)
The change does make sense, but makes me wonder why we need to single this one out in a separate patch. Doesn't this fall into the same category of fixes done in 3/3? Exactly the same rationale as above applies to the first one in 3/3 on t0021---we can safely lose the cat because the file is immediately grepped for a string, so missing file will be caught as an error either way.
Puzzled...
Show 12 quoted lines
> diff --git a/t/t9810-git-p4-rcs.sh b/t/t9810-git-p4-rcs.sh > index 57b533dc6f..e3836888ec 100755 > --- a/t/t9810-git-p4-rcs.sh > +++ b/t/t9810-git-p4-rcs.sh > @@ -294,7 +294,6 @@ test_expect_success 'cope with rcs keyword file deletion' ' > echo "\$Revision\$" >kwdelfile.c && > p4 add -t ktext kwdelfile.c && > p4 submit -d "Add file to be deleted" && > - cat kwdelfile.c && > grep 1 kwdelfile.c > ) && > git p4 clone --dest="$git" //depot &&