git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t: drop debug `cat` calls

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2020, 20:49 UTC
Message-ID
<xmqq8skrpv6z.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAN0heSo8RSyvTqTtDLcnBsvMJ-DLL_B-sKRZDNUZBhZ1yX=bmQ@mail.gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> For the first patch 1/3, if we lose the cat entirely, we risk bugs in
> *git* being hidden.

Yes, as Peff already said, the change to explicitly test if the file exists makes perfect sense.

Show 5 quoted lines
> For the hunk in patch 2/3, I first thought it was in the same
> category, before I realized that kwdelfile.c disappearing would be
> a bug in *p4* as opposed to *git p4*.  Since we're not in the
> business of testing/verifying other people's software, we can
> afford to drop that call entirely.

It is ">kwdelfile.c" shell redirection that creates that file. I agree with you that preparing for a bug that "p4 add -t ktext kwdelfile.c" or "p4 submit" removes the file is a little too much.

Previous: Martin ÅgrenNext: Jeff King
Message 7 of 8 in “t4117: check for files using `test_path_is_file`”
  1. 1/3 t4117: check for files using `test_path_is_file`Martin Ågren, Feb 23, 2020
  2. 2/3 t9810: drop debug `cat` callMartin Ågren, Feb 23, 2020
  3. Junio C HamanoFeb 24, 2020
  4. 3/3 t: drop debug `cat` callsMartin Ågren, Feb 23, 2020
  5. Junio C HamanoFeb 24, 2020
  6. Martin ÅgrenFeb 24, 2020
  7. Junio C HamanoFeb 24, 2020
  8. Jeff KingFeb 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.