git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] t9810: drop debug `cat` call

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Feb 23, 2020, 08:48 UTC
Message-ID
<ef45c9cabe7fe3f31d63edb872ba946ffbd951fe.1582447606.git.martin.agren@gmail.com>
In-Reply-To
<dde0f85e5e3dd99a61b83df1b6eb572be8a3ff51.1582447606.git.martin.agren@gmail.com>

We `cat` kwdelfile.c, but don't inspect or grab the contents in any way. This looks like a remnant from a debug session. Similar to the previous commit, one could argue that `cat`-ing the file verifies that it didn't disappear somehow. But because the very next thing we do after `cat`-ing the file is to `grep` in it, we can safely drop the call to `cat`.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 t/t9810-git-p4-rcs.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t9810-git-p4-rcs.sh b/t/t9810-git-p4-rcs.sh
index 57b533dc6f..e3836888ec 100755
--- a/t/t9810-git-p4-rcs.sh
+++ b/t/t9810-git-p4-rcs.sh
@@ -294,7 +294,6 @@ test_expect_success 'cope with rcs keyword file deletion' '
 		echo "\$Revision\$" >kwdelfile.c &&
 		p4 add -t ktext kwdelfile.c &&
 		p4 submit -d "Add file to be deleted" &&
-		cat kwdelfile.c &&
 		grep 1 kwdelfile.c
 	) &&
 	git p4 clone --dest="$git" //depot &&
-- 
2.25.0
Previous: Martin ÅgrenNext: Junio C Hamano
Message 2 of 8 in “t4117: check for files using `test_path_is_file`”
  1. 1/3 t4117: check for files using `test_path_is_file`Martin Ågren, Feb 23, 2020
  2. 2/3 t9810: drop debug `cat` callMartin Ågren, Feb 23, 2020
  3. Junio C HamanoFeb 24, 2020
  4. 3/3 t: drop debug `cat` callsMartin Ågren, Feb 23, 2020
  5. Junio C HamanoFeb 24, 2020
  6. Martin ÅgrenFeb 24, 2020
  7. Junio C HamanoFeb 24, 2020
  8. Jeff KingFeb 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.