Re: [PATCH v2 1/2] t5537: use test_write_lines, indented heredocs for readability
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 24, 2020, 20:45 UTC
- Message-ID
- <xmqqpnbwbojr.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200424171139.GA61470@syl.local>
Taylor Blau <me@ttaylorr.com> writes:
> Subject: [PATCH] t5537: use test_write_lines, indented heredocs for readability
Assuming that "indented" is not a verb in the past tense, but adjective on the noun "heredocs", this reads well, but "s/,/ and/" would make it more clear in that case. Or "for readability, use X and indent Y" would work equally well.
But the original is probably OK as-is.
Show 5 quoted lines
> - cat <<EOF >expect && > -4 > -3 > -EOF > + test_write_lines 4 3 >expect &&
Yeah, becomes much nicer with test_write_lines.
Thanks.