git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] shallow.c: reset shallow-ness after updating

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 23, 2020, 00:25 UTC
Message-ID
<cover.1587601501.git.me@ttaylorr.com>
In-Reply-To
<20200423001438.GC19100@syl.local>
Hi,

Here is an updated version of the patch that I sent above (which was itself an updated version of a patch that I sent to some other sub-thread...).

In this version, I added an extra patch at the beginning to clean up some surrounding tests in t5537 so the new ones are added both in a good style, and in a way that is consistent with the surrounding code.

I also adopted a suggestion from Junio that introduces '{commit,rollback}_shallow_file()' as thin wrappers around '{commit,rollback}_lock_file()', which makes this whole thing a lot tidier.

Thanks in advance for another look...
Taylor Blau (2):
  t5537: use test_write_lines, indented heredocs for readability
  shallow.c: use '{commit,rollback}_shallow_file'
 builtin/receive-pack.c   |  4 +-
 commit.h                 |  2 +
 fetch-pack.c             | 10 ++--
 shallow.c                | 30 ++++++++----
 t/t5537-fetch-shallow.sh | 99 +++++++++++++++++++---------------------
 5 files changed, 77 insertions(+), 68 deletions(-)

-- 2.26.0.113.ge9739cdccc

Previous: Taylor BlauNext: Taylor Blau
Message 11 of 32 in “shallow.c: use 'reset_repository_shallow' when appropriate”
  1. shallow.c: use 'reset_repository_shallow' when appropriateTaylor Blau, Apr 21, 2020
  2. Junio C HamanoApr 21, 2020
  3. Taylor BlauApr 21, 2020
  4. Junio C HamanoApr 21, 2020
  5. Taylor BlauApr 21, 2020
  6. Junio C HamanoApr 21, 2020
  7. Jonathan TanApr 22, 2020
  8. Jonathan TanApr 22, 2020
  9. Junio C HamanoApr 22, 2020
  10. Taylor BlauApr 23, 2020
  11. 0/2 shallow.c: reset shallow-ness after updatingTaylor Blau, Apr 23, 2020
  12. 1/2 t5537: use test_write_lines, indented heredocs for readabilityTaylor Blau, Apr 23, 2020
  13. Jonathan NiederApr 23, 2020
  14. Taylor BlauApr 24, 2020
  15. Jonathan NiederApr 24, 2020
  16. Junio C HamanoApr 24, 2020
  17. 2/2 shallow.c: use '{commit,rollback}_shallow_file'Taylor Blau, Apr 23, 2020
  18. Jonathan NiederApr 23, 2020
  19. Jonathan TanApr 23, 2020
  20. Junio C HamanoApr 23, 2020
  21. Taylor BlauApr 24, 2020
  22. Jonathan NiederJun 3, 2020
  23. Taylor BlauJun 3, 2020
  24. Taylor BlauJun 3, 2020
  25. Derrick StoleeJun 3, 2020
  26. Taylor BlauJun 3, 2020
  27. Jonathan NiederJun 3, 2020
  28. Jonathan NiederJun 3, 2020
  29. Taylor BlauJun 3, 2020
  30. Jonathan NiederJun 3, 2020
  31. Taylor BlauJun 4, 2020
  32. Junio C HamanoApr 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.