Re: [PATCH v2 0/3] Prepare git credential to read input with DOS line endings

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2020, 20:31 UTC
Message-ID: <xmqqpn65lk2s.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.710.v2.git.git.1601293224.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> This contribution came in via Git for Windows
> [https://github.com/git-for-windows/git/pull/2516].
>
> Sadly, I did not find the time to go through all the changes of 8f309aeb
> ("strbuf: introduce strbuf_getline_{lf,nul}()", 2016-01-13) (as Junio asked
> [https://public-inbox.org/git/xmqqmu9lnjdh.fsf@gitster-ct.c.googlers.com]).
> Rather than delaying this patch indefinitely, I admit defeat on that angle.

Oh, that's OK. Thanks for resurrecting the stalled patch. I didn't mean the suggested action while I was waiting to be an exhaustive audit---I merely wanted to avoid having to queue a few more separate ones soon after applying a patch for just a single place.

> Changes since v1:
>
>  * Added a commit to adjust credential-daemon and credential-store in the
>    same manner.

I am kind of surprised to see that these need to be touched at all.

The change to credential-store is sort-of understandable, as the file it uses could be hand-modified in an editor and its line ending could have been changed to CRLF, hence it needs to be prepared.

But does inter-process communication with the daemon need to care about CRLF line endings? Do parts of the protocol within the credential system use platform specific line ending?