Re: [PATCH v2 2/3] credentials: make line reading Windows compatible

From: Jeff King <peff@peff.net>
Date: Oct 1, 2020, 13:54 UTC
Message-ID: <20201001135417.GA3145610@coredump.intra.peff.net>
In-Reply-To: <xmqq5z7ug9gk.fsf@gitster.c.googlers.com>

On Wed, Sep 30, 2020 at 03:56:27PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> > Other than those nits, I think the series is OK.
> 
> Sure.  But credential-store side is also iffy; it is not like they
> want CRLF on data lines (if they want CR in data, that needs to be
> encoded).  The only reason I can think of that the change to
> "-store" makes any difference is when people edit it, but the file
> is not designed to be manually edited, so even that part of the
> series needs a better justification.  It's not like "We want to be
> compatible" without "why it is better to be compatible" is a good
> rationale, when we define the file format not to be manually edited
> in the first place.

Yeah, I agree that just teaching git-credential's stdin to handle CR would be an OK stopping point. I don't have a strong opinion on credential-store's on disk format. At least allowing CRLF there is _plausibly_ useful, unlike credential-cache--daemon's pipe. And I doubt that making the change would hurt anybody.

-Peff