Re: [PATCH v2 2/3] credentials: make line reading Windows compatible

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 2, 2020, 08:07 UTC
Message-ID: <nycvar.QRO.7.76.6.2010021004080.50@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqpn62c5q7.fsf@gitster.c.googlers.com>

Hi,

On Thu, 1 Oct 2020, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
>
> > Yeah, I agree that just teaching git-credential's stdin to handle CR
> > would be an OK stopping point. I don't have a strong opinion on
> > credential-store's on disk format. At least allowing CRLF there is
> > _plausibly_ useful, unlike credential-cache--daemon's pipe. And I doubt
> > that making the change would hurt anybody.
>
> I agree 100% with all of the above, including the part that says it
> is also OK to let credential-store read from its files with line
> ending converted to CRLF.

After mulling over this, I am more inclined to drop the credential-store changes, too. That file _is_ an implementation detail, and not intended for interactive editing. And as Carlo pointed out so correctly, the regression tests were not introduced "just for fun", they really want to make sure that we keep handling CR/LF the way we currently do.

So I will drop both credential-cache--daemon and credential-store changes from the next iteration.

Ciao, Dscho