git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] tests: make sure nested lazy prereqs work reliably

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 20, 2020, 00:07 UTC
Message-ID
<xmqqpn48vqkq.fsf@gitster.c.googlers.com>
In-Reply-To
<20201119155824.GB25426@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Wed, Nov 18, 2020 at 08:04:13PM +0100, SZEDER Gábor wrote:
>
>> So to prevent nested prereqs from interfering with each other let's
>> evaluate each prereq in its own dedicated directory by appending the
>> prereq's name to the directory name, e.g. 'prereq-test-dir-SYMLINKS'.
>> In the test we check not only that the prereq test dir is still there,
>> but also that the inner prereq can't mess with the outer prereq's
>> files.
>
> That sounds reasonable. I do wonder, though, whether simply creating the
> prereq directory in the _current_ directory would be sufficient. Then
> you'd get prereq-test-dir/prereq-test-dir for a nested invocation. But
> the prereqs aren't supposed to care about which specific directory
> they're in.

True. That does sound conceptually simpler. As we've already seen the patch, I do not mind too deeply either way, though.

Thanks.
Previous: Junio C Hamano
Message 13 of 13 in “tests: make sure nested lazy prereqs work reliably”
  1. 1/2 tests: make sure nested lazy prereqs work reliablySZEDER Gábor, Nov 18, 2020
  2. 2/2 tests: fix description of 'test_set_prereq'SZEDER Gábor, Nov 18, 2020
  3. Junio C HamanoNov 18, 2020
  4. Jeff KingNov 19, 2020
  5. Jeff KingNov 19, 2020
  6. Junio C HamanoNov 19, 2020
  7. Jeff KingNov 20, 2020
  8. 1/4 t0000: keep clean-up tests togetherJeff King, Nov 20, 2020
  9. 2/4 t0000: run prereq tests inside sub-testJeff King, Nov 20, 2020
  10. 3/4 t0000: run cleaning test inside sub-testJeff King, Nov 20, 2020
  11. 4/4 t0000: consistently use single quotes for outer testsJeff King, Nov 20, 2020
  12. Junio C HamanoNov 20, 2020
  13. Junio C HamanoNov 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.