Re: [PATCH 1/2] tests: make sure nested lazy prereqs work reliably

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2020, 01:32 UTC
Message-ID: <xmqqlfewvmmj.fsf@gitster.c.googlers.com>
In-Reply-To: <20201120001458.GA274082@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> OK, then here's the whole thing. I ended up with a few more cleanups,
> too. This is all on top of Gábor's patches. It's conceptually
> independent, but the textual wrangling was annoying enough it didn't
> make any sense to require you to do it again during merging. ;) Plus I
> do not think either topic is high-risk nor urgent enough to worry too
> much about one blocking the other.

I'll ask you to do the last step maybe in a few weeks; the range notation tests seem to have changed since where I queued Gábor's patches and where [4/4] is based on (yours is based on newer codebase).

> The diffstat is scary, but it's mostly the final patch, which is pretty
> mechanical.

Yup, and the result is much easier to read.

Thanks.

Show 9 quoted lines

>   [1/4]: t0000: keep clean-up tests together
>   [2/4]: t0000: run prereq tests inside sub-test
>   [3/4]: t0000: run cleaning test inside sub-test
>   [4/4]: t0000: consistently use single quotes for outer tests
>
>  t/t0000-basic.sh | 570 +++++++++++++++++++++++------------------------
>  1 file changed, 284 insertions(+), 286 deletions(-)
>
> -Peff