git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] tests: make sure nested lazy prereqs work reliably

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2020, 19:50 UTC
Message-ID
<xmqqd009xh19.fsf@gitster.c.googlers.com>
In-Reply-To
<20201119175608.GA132922@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> I took a look at converting some of the existing tests. This seems to
> work. It's a bit longer to read, perhaps, but I kind of like that the
> expected outcome is all laid out. It also pollutes the test output less
> (e.g., if you wanted to count up skipped tests in the whole suite, you'd
> get a bunch of noise from t0000 for these uninteresting skips).
>
> Thoughts? I think this is something I'd do on top of your patch.
Yes, it looks nice as the expectation is expressed much clearly.
Previous: Jeff KingNext: Jeff King
Message 6 of 13 in “tests: make sure nested lazy prereqs work reliably”
  1. 1/2 tests: make sure nested lazy prereqs work reliablySZEDER Gábor, Nov 18, 2020
  2. 2/2 tests: fix description of 'test_set_prereq'SZEDER Gábor, Nov 18, 2020
  3. Junio C HamanoNov 18, 2020
  4. Jeff KingNov 19, 2020
  5. Jeff KingNov 19, 2020
  6. Junio C HamanoNov 19, 2020
  7. Jeff KingNov 20, 2020
  8. 1/4 t0000: keep clean-up tests togetherJeff King, Nov 20, 2020
  9. 2/4 t0000: run prereq tests inside sub-testJeff King, Nov 20, 2020
  10. 3/4 t0000: run cleaning test inside sub-testJeff King, Nov 20, 2020
  11. 4/4 t0000: consistently use single quotes for outer testsJeff King, Nov 20, 2020
  12. Junio C HamanoNov 20, 2020
  13. Junio C HamanoNov 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.