Re: [PATCH 00/12] Remove more index compatibility macros
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 6, 2021, 20:52 UTC
- Message-ID
- <xmqqpn2hrdo1.fsf@gitster.c.googlers.com>
- In-Reply-To
- <a93359c3-66bf-80bc-f053-4742563163d0@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
> My intention was to reduce the use of globals in libgit.a while keeping > with existing patterns of static globals in the builtin code.
The above (without having thought about it too hard or long enough yet) sounds a sensible guideline to go by. Thanks for a helpful hint to keep in mind while reading the series.
> While > this can be thought of "module variables" instead of true globals, they > aren't exactly desirable. In v2, these static globals are temporary to > the series and are completely removed by the end.
;-)