From: Junio C Hamano Date: Wed, 06 Jan 2021 20:52:30 GMT Subject: Re: [PATCH 00/12] Remove more index compatibility macros Message-ID: In-Reply-To: Derrick Stolee writes: > My intention was to reduce the use of globals in libgit.a while keeping > with existing patterns of static globals in the builtin code. The above (without having thought about it too hard or long enough yet) sounds a sensible guideline to go by. Thanks for a helpful hint to keep in mind while reading the series. > While > this can be thought of "module variables" instead of true globals, they > aren't exactly desirable. In v2, these static globals are temporary to > the series and are completely removed by the end. ;-)