Re: [PATCH v3 00/14] Remove more index compatibility macros

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2021, 07:03 UTC
Message-ID: <xmqq1retclzr.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.830.v3.git.1610136177.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> UPDATE: this is now based on ag/merge-strategies-in-c to avoid conflicts in
> 'seen'. The changes in builtin/rm.c still conflict with
> mt/rm-sparse-checkout, but that branch seems to be waiting for a clearer
> plan on some corner cases. I thought about ejecting it, but 'rm' still uses
> ce_match_stat(), so just dropping the patch gives less of a final stake at
> the end of the series. (I'm still open to it, if necessary.)

I haven't read this latest iteration myself yet beyond the cover letter, but tonight's 'seen' has this queued near its tip. I expect it would either stay there or occasionally ejected, until the base topic solidifies a bit more.

Show 5 quoted lines

>  * Methods that know about the 'repo' pointer no longer also have an
>    'istate' pointer and instead prefer 'repo->index'
>
>  * This includes the callback_data struct which only has a 'repo' member, no
>    'istate'.

OK.