Re: [PATCH] name-rev: use generation numbers if available

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2022, 02:36 UTC
Message-ID: <xmqqpmn6wg98.fsf@gitster.g>
In-Reply-To: <20220228215025.325904-3-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

Show 13 quoted lines

> +test_expect_success 'name-rev without commitGraph does not handle non-monotonic timestamps' '
> +	test_config -C non-monotonic core.commitGraph false &&
> +	(
> +		cd non-monotonic &&
> +
> +		rm -rf .git/info/commit-graph* &&
> +
> +		echo "main~3 undefined" >expect &&
> +		git name-rev --tags main~3 >actual &&
> +
> +		test_cmp expect actual
> +	)
> +'

I doubt it is wise to "test" that a program does _not_ produce a correct output, or even worse, it produces a particular wrong output. This test, for example, casts in stone that any future optimization that does not depend on the commit-graph is forever prohibited.

Just dropping the test would be fine, I would think.