Re: [PATCH] name-rev: use generation numbers if available

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2022, 20:22 UTC
Message-ID: <xmqqfso1pgmv.fsf@gitster.g>
In-Reply-To: <3c3e6063-7eb4-7ff4-3a1b-a07db1fe969f@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 8 quoted lines

>> I think the "tests should document current behavior" is handled by the
>> fact that this specific test fails if you revert the name-rev changes
>> but keep the test.
>
> Ah, so this _is_ documenting a new behavior that didn't exist
> before the series. That is good to include, then. If it was
> "just" testing the behavior before this series, then it would
> have less reason to exist.

With of without the additional codepath to handle the case where commit graph is available, the original heuristics that is based on commit timestamps are fooled by a history with skewed timestamps.

So I thought this "without commit graph, the algorithm must fail this way" test would be testing the current behaviour *and* the behaviour of the new code, no?