Re: [PATCH v2 7/7] var: add config file locations

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 26, 2023, 20:02 UTC
Message-ID: <xmqqpm5i3sbu.fsf@gitster.g>
In-Reply-To: <20230626190008.644769-8-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 17 quoted lines

>  struct git_var {
>  	const char *name;
>  	char *(*read)(int);
> +	int multivalued;
>  };
>  static struct git_var git_vars[] = {
>  	{
>  		.name = "GIT_COMMITTER_IDENT",
>  		.read = committer,
> +		.multivalued = 0,
>  	},
> ...
> +	{
> +		.name = "GIT_CONFIG_GLOBAL",
> +		.read = git_config_val_global,
> +		.multivalued = 1,
>  	},

As the majority of the variables are singletons and multi-valued variables are expected to be in minority even in the future, we would probably want to leave ".multivalued = 0" out of these array elements and instead let the default zero initialization to take place, which would make the resulting source less noisy.

Other than that, looks good.

Thanks.