Re: [PATCH 1/3] var: add support for listing the shell

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2023, 21:05 UTC
Message-ID: <xmqqjzvvdx7g.fsf@gitster.g>
In-Reply-To: <CAPig+cSTR6oHeYjcHZ7m2CKYcFo2eistxz_X-7J2rhd7h+uf3g@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> This can be implemented more simply without a temporary file:
>
>     shpath=$(git var GIT_SHELL_PATH) &&
>     test -x "$shpath"
>
> This is safe since the exit code of the Git command is preserved
> across the `shpath=...` assignment.

Correct. I also suspect that we want to add test_path_is_executable helper next to test_path_is_{file,dir,missing} helpers and list it in t/README. One downside of your approach is that the output from the command is only in $shpath and cannot be observed easily in the $TRASH_DIRECTORY after the test fails, but with such a helper we can report the problematic path when the expectation fails.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.