Re: [PATCH 3/4] Fix comma warnings with clang on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2025, 23:51 UTC
Message-ID: <xmqqplfkfkol.fsf@gitster.g>
In-Reply-To: <20250603230646.2322671-3-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> Subject: Re: [PATCH 3/4] Fix comma warnings with clang on Windows

Common to all four patches, as "Fix" does not quite tell the story, please choose more appropriate verb. For example, judging from how this was rewritten ...

Show 6 quoted lines

> -	if ((oflags & ~O_CREAT) != (O_WRONLY | O_APPEND))
> -		return errno = ENOSYS, -1;
> +	if ((oflags & ~O_CREAT) != (O_WRONLY | O_APPEND)) {
> +		errno = ENOSYS;
> +		return -1;
> +	}

... the warning is a false positive (i.e. the code does what the author intended it to do), so this is more like "squelching" the warning.

I obviously like the style after this patch. I just thought that the proposed log message, especially its title, were not clear enough to tell which ones are real fixes and which ones are workarounds.

Thanks.