Re: [PATCH 4/4] Fix unreachable-code warning with clang on Windows

From

Junio C Hamano <gitster@pobox.com>

Date

Jun 4, 2025, 15:50 UTC

Message-ID

<xmqq8qm7cxq3.fsf@gitster.g>

In-Reply-To

<aD_3ahX2jyrtfvjq@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> The function won't cause the error, but the macro will. So wouldn't it
> make more sense to wrap the macro itself in `NOT_CONSTANT`, like this:
>
>     #define create_ref_symlink(a, b) NOT_CONSTANT(-1)

That's clever ;-).