Re: [PATCH 1/4] Fix maybe-uninitialized warning with GCC at -O3

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 4, 2025, 07:36 UTC
Message-ID: <aD_3Y0PQtfg8Dd9z@pks.im>
In-Reply-To: <20250603230646.2322671-1-mh@glandium.org>

On Wed, Jun 04, 2025 at 08:06:43AM +0900, Mike Hommey wrote:

Show 10 quoted lines

> ```
> In file included from parse-options.c:1:
> git-compat-util.h: In function ‘get_value’:
> git-compat-util.h:489:21: error: ‘arg’ may be used uninitialized [-Werror=maybe-uninitialized]
>   489 | #define error(...) (error(__VA_ARGS__), const_error())
>       |                     ^~~~~
> parse-options.c:76:21: note: ‘arg’ was declared here
>    76 |         const char *arg;
>       |                     ^~~
> ```

A bit more explanation whether this warning is a false positive or whether this may be an actual issue would be welcome.

Patrick