Re: [PATCH v4 2/2] revision.c: reduce memory usage on reverse before
Mirko Faina <mroik@delayed.space> writes:
Show 9 quoted lines
> reversed = NULL;
> - while ((c = get_revision_internal(revs)))
> - commit_list_insert(c, &reversed);
> + if (revs->reverse == REVERSE_BEFORE && max_count >= 0) {
> + retrieve_with_window(revs, max_count, &reversed);
> + } else {
> + while ((c = get_revision_internal(revs)))
> + commit_list_insert(c, &reversed);
> + }Style: needless {} around single-statement body of if/else.> commit_list_free(revs->commits);
> revs->commits = reversed;
> revs->reverse_output_stage = 1;
Junio C Hamano <gitster@pobox.com>