From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 28 Apr 2026 01:46:05 GMT
Subject: Re: [PATCH v4 2/2] revision.c: reduce memory usage on reverse before
Message-ID: <xmqqpl3j26xu.fsf@gitster.g>
In-Reply-To: <7c0bab5d14bb2ce2a10d35d93e3d911ed4c386eb.1777249165.git.mroik@delayed.space>

Mirko Faina <mroik@delayed.space> writes:

>  		reversed = NULL;
> -		while ((c = get_revision_internal(revs)))
> -			commit_list_insert(c, &reversed);
> +		if (revs->reverse == REVERSE_BEFORE && max_count >= 0) {
> +			retrieve_with_window(revs, max_count, &reversed);
> +		} else {
> +			while ((c = get_revision_internal(revs)))
> +				commit_list_insert(c, &reversed);
> +		}

Style: needless {} around single-statement body of if/else.

>  		commit_list_free(revs->commits);
>  		revs->commits = reversed;
>  		revs->reverse_output_stage = 1;