git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/2] revision.c: implement --reverse=before for walks

From
Mirko Faina <mroik@delayed.space>
Date
Apr 23, 2026, 22:51 UTC
Message-ID
<cover.1776984666.git.mroik@delayed.space>
In-Reply-To
<20260422002840.303477-4-mroik@delayed.space>

I've fixed the docs with the suggested changes by Jeff and applied some styling fixes.

[1/2] revision.c: implement --reverse=before for walks (Mirko Faina) [2/2] revision.c: reduce memory usage on reverse before (Mirko Faina)

 Documentation/rev-list-options.adoc | 16 +++++--
 revision.c                          | 73 +++++++++++++++++++++++++++--
 revision.h                          |  8 +++-
 t/t4202-log.sh                      | 66 ++++++++++++++++++++++++++
 4 files changed, 153 insertions(+), 10 deletions(-)
Range-diff against v2:
1:  599a247d82 ! 1:  4864ac46dd revision.c: implement --reverse=before for walks
    @@ Documentation/rev-list-options.adoc: With `--topo-order`, they would show 8 6 5
     +	`--walk-reflogs`. If `after`, output the commits chosen to be
     +	shown (see 'Commit Limiting' section above) in reverse order. If
     +	`before`, reverse the commits before filtering with `Commit
    -+	Limiting` options. This option can be used multiple times, last
    -+	one is applied. When the argument for `--reverse` is omitted, if
    -+	the current state is in no reverse, it defaults to `after`. If
    -+	it is in any reversed state, it restores the original ordering
    -+	by removing the reverse state.
    ++	Limiting` options. When multiple `--reverse=` options are given,
    ++	the final option overrides any previous options. The `--reverse`
    ++	option (with no specifier) behaves as `--reverse=after`, except
    ++	that, for historical reasons, it negates any previous reversed
    ++	state (so `--reverse --reverse` does nothing, nor does
    ++	`--reverse=before --reverse`. Note that `--reverse=before
    ++	--reverse --reverse` is the same as `--reverse=after`).
      endif::git-shortlog[]
      
      ifndef::git-shortlog[]
2:  480b322cf8 ! 2:  00489b0e52 revision.c: reduce memory usage on reverse before
    @@ revision.c: static struct commit *get_revision_internal(struct rev_info *revs)
      }
      
     +static void retrieve_with_window(struct rev_info *revs, int max_count,
    -+			  struct commit_list **reversed)
    ++			  	 struct commit_list **reversed)
     +{
     +	struct commit *c;
     +	struct commit_list *into_queue = NULL;
    @@ revision.c: static struct commit *get_revision_internal(struct rev_info *revs)
     +		}
     +	}
     +
    -+	while (outo_count) {
    -+		c = pop_commit(&outo_queue);
    -+		outo_count--;
    ++	while ((c = pop_commit(&outo_queue)))
     +		commit_list_insert(c, reversed);
    -+	}
    -+
    -+	while (into_count) {
    -+		c = pop_commit(&into_queue);
    -+		into_count--;
    ++	while ((c = pop_commit(&into_queue)))
     +		commit_list_insert(c, &outo_queue);
    -+		outo_count++;
    -+	}
    -+
    -+	while (outo_count) {
    -+		c = pop_commit(&outo_queue);
    -+		outo_count--;
    ++	while ((c = pop_commit(&outo_queue)))
     +		commit_list_insert(c, reversed);
    -+	}
     +}
     +
      struct commit *get_revision(struct rev_info *revs)
-- 
2.54.0
Previous: Mirko FainaNext: Mirko Faina
Message 22 of 63 in “revision.c: implement --reverse=before for walks”
  1. revision.c: implement --reverse=before for walksMirko Faina, Apr 18, 2026
  2. Tian YuchenApr 18, 2026
  3. Mirko FainaApr 18, 2026
  4. Mirko FainaApr 18, 2026
  5. Junio C HamanoApr 20, 2026
  6. Tian YuchenApr 20, 2026
  7. Mirko FainaApr 20, 2026
  8. Ben KnobleApr 19, 2026
  9. Mirko FainaApr 19, 2026
  10. D. Ben KnobleApr 19, 2026
  11. Mirko FainaApr 19, 2026
  12. Jeff KingApr 20, 2026
  13. Mirko FainaApr 20, 2026
  14. Mirko FainaApr 20, 2026
  15. Jeff KingApr 21, 2026
  16. D. Ben KnobleApr 22, 2026
  17. Mirko FainaApr 22, 2026
  18. Jeff KingApr 20, 2026
  19. Mirko FainaApr 20, 2026
  20. 0/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 22, 2026
  21. Mirko FainaApr 22, 2026
  22. 0/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 23, 2026
  23. 2/2 revision.c: reduce memory usage on reverse beforeMirko Faina, Apr 23, 2026
  24. 1/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 23, 2026
  25. Junio C HamanoApr 28, 2026
  26. 0/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 27, 2026
  27. 2/2 revision.c: reduce memory usage on reverse beforeMirko Faina, Apr 27, 2026
  28. Junio C HamanoApr 28, 2026
  29. 1/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 27, 2026
  30. Junio C HamanoApr 27, 2026
  31. Johannes SixtApr 27, 2026
  32. Junio C HamanoApr 27, 2026
  33. Chris TorekApr 27, 2026
  34. Mirko FainaApr 27, 2026
  35. Junio C HamanoApr 28, 2026
  36. Junio C HamanoApr 28, 2026
  37. revision.c: implement --max-count-oldestMirko Faina, Apr 30, 2026
  38. Junio C HamanoMay 4, 2026
  39. Mirko FainaMay 4, 2026
  40. revision.c: implement --max-count-oldestMirko Faina, May 5, 2026
  41. Johannes SixtMay 6, 2026
  42. Mirko FainaMay 6, 2026
  43. Junio C HamanoMay 7, 2026
  44. Mirko FainaMay 8, 2026
  45. Jean-Noël AVILAMay 9, 2026
  46. Mirko FainaMay 10, 2026
  47. Junio C HamanoMay 9, 2026
  48. Mirko FainaMay 10, 2026
  49. revision.c: implement --max-count-oldestMirko Faina, May 15, 2026
  50. revision.c: implement --max-count-oldestMirko Faina, May 19, 2026
  51. Mirko FainaMay 19, 2026
  52. Junio C HamanoMay 20, 2026
  53. Mirko FainaMay 20, 2026
  54. revision.c: implement --max-count-oldestJunio C Hamano, Jun 1, 2026
  55. Mirko FainaJun 2, 2026
  56. Junio C HamanoMay 19, 2026
  57. Mirko FainaMay 19, 2026
  58. Junio C HamanoMay 9, 2026
  59. Mirko FainaMay 10, 2026
  60. 2/2 revision.c: reduce memory usage on reverse beforeMirko Faina, Apr 22, 2026
  61. 1/2 revision.c: implement --reverse=before for walksMirko Faina, Apr 22, 2026
  62. Jeff KingApr 22, 2026
  63. Mirko FainaApr 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.