git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] credential/libsecret: load secrets explicitly

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2026, 09:31 UTC
Message-ID
<xmqqpkwnlgv1.fsf@gitster.g>
In-Reply-To
<pull.2372.v2.git.git.1790549181518.gitgitgadget@gmail.com>
"Daniel Martí via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
>
> keyring_get() searches with SECRET_SEARCH_LOAD_SECRETS, then passes
> secret_item_get_secret() of the first match unchecked to
> ...
> An inaccessible item now produces a useful error message instead of
> the assertion failures, and git still falls back to prompting. The
> race needs a concurrent process or a locked keyring to trigger, so
> there is no test.
>
> Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
> ---

It seems that unfortunately we saw interest or reviews from nobody since this v2 was sent. Anybody interested enough to review it now to resurrect?

Unless we see some volunteers to give it a review in a few weeks, I will discard the topic out of my tree, as 'seen' has been crowded with topics that have been collecting dust without getting many reviews.

Previous: Daniel MartíNext: Phillip Wood
Message 11 of 12 in “credential/libsecret: load secrets explicitly”
  1. credential/libsecret: load secrets explicitlyDaniel Martí via GitGitGadget, Aug 4, 2026
  2. Daniel MartíAug 20, 2026
  3. Junio C HamanoAug 20, 2026
  4. Daniel MartíAug 22, 2026
  5. Daniel MartíSep 21, 2026
  6. Junio C HamanoSep 21, 2026
  7. M HickfordSep 24, 2026
  8. Daniel MartíSep 27, 2026
  9. credential/libsecret: load secrets explicitlyDaniel Martí via GitGitGadget, Sep 27, 2026
  10. Daniel MartíSep 28, 2026
  11. Junio C HamanoNov 2, 2026
  12. Phillip WoodNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.