git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] credential/libsecret: load secrets explicitly

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 21, 2026, 22:52 UTC
Message-ID
<xmqqv77yjjys.fsf@gitster.g>
In-Reply-To
<c3f51472-8dfa-42df-aa8b-b0f5bfd0aafe@mvdan.cc>
Daniel Martí <mvdan@mvdan.cc> writes:
> Friendly nudge :) Happy to look into any tweaks or questions.

We have had a review exchange. A reviewer had to ask questions on the points where the code and the proposed log message weren't clear. The ball is now in the author's court to improve the patch to the point that the next reviewer who did not see the first exchange would not have to ask the same questions.

Thanks for working on this topic.
Previous: Daniel MartíNext: M Hickford
Message 6 of 10 in “credential/libsecret: load secrets explicitly”
  1. credential/libsecret: load secrets explicitlyDaniel Martí via GitGitGadget, Aug 4, 2026
  2. Daniel MartíAug 20, 2026
  3. Junio C HamanoAug 20, 2026
  4. Daniel MartíAug 22, 2026
  5. Daniel MartíSep 21, 2026
  6. Junio C HamanoSep 21, 2026
  7. M HickfordSep 24, 2026
  8. Daniel MartíSep 27, 2026
  9. credential/libsecret: load secrets explicitlyDaniel Martí via GitGitGadget, Sep 27, 2026
  10. Daniel MartíSep 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.