From: Junio C Hamano Date: Mon, 02 Nov 2026 09:31:14 GMT Subject: Re: [PATCH v2] credential/libsecret: load secrets explicitly Message-ID: In-Reply-To: "Daniel Martí via GitGitGadget" writes: > From: =?UTF-8?q?Daniel=20Mart=C3=AD?= > > keyring_get() searches with SECRET_SEARCH_LOAD_SECRETS, then passes > secret_item_get_secret() of the first match unchecked to > ... > An inaccessible item now produces a useful error message instead of > the assertion failures, and git still falls back to prompting. The > race needs a concurrent process or a locked keyring to trigger, so > there is no test. > > Signed-off-by: Daniel Martí > --- It seems that unfortunately we saw interest or reviews from nobody since this v2 was sent. Anybody interested enough to review it now to resurrect? Unless we see some volunteers to give it a review in a few weeks, I will discard the topic out of my tree, as 'seen' has been crowded with topics that have been collecting dust without getting many reviews.