Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2014, 20:31 UTC
- Message-ID
- <xmqqoavwjb3i.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <vpq61i4nld7.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 8 quoted lines
>>> Why is this needed? Are you now using key_value_info outside config.c? >>> Or is it a leftover from a previous experiment? >> >> Has this been resolved in the new round? > > Tanay explained in another subthread why this was needed. For callers > iterating over the string_list who want to get the file/line info, they > need to be able to cast the void * pointer to struct key_value_info *.
For callers that want to see all the multi-values, it would be preferrable for the iterator to pass the filename and the linenumber to the callback function, instead of exposing its implementation detail as a single string list and telling them to pick it apart, no?
Not a very convincing argument, but OK for now in the sense that we can fix it later if we wanted to before it gets too late.