Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Aug 6, 2014, 15:26 UTC
- Message-ID
- <vpqy4v1vdui.fsf@anie.imag.fr>
- In-Reply-To
- <1407336792-16962-1-git-send-email-tanayabh@gmail.com>
Tanay Abhra <tanayabh@gmail.com> writes:
> --- a/cache.h > +++ b/cache.h > @@ -1406,8 +1406,14 @@ extern int git_config_get_bool(const char *key, int *dest);
[...]
> +struct key_value_info {
> + const char *filename;
> + int linenr;
> +};[...]
Show 13 quoted lines
> diff --git a/config.c b/config.c
> index cf9124f..427850a 100644
> --- a/config.c
> +++ b/config.c
> @@ -1224,11 +1224,6 @@ int git_config_with_options(config_fn_t fn, void *data,
> return ret;
> }
>
> -struct key_value_info {
> - const char *filename;
> - int linenr;
> -};
> -Why is this needed? Are you now using key_value_info outside config.c? Or is it a leftover from a previous experiment?
-- Matthieu Moy http://www-verimag.imag.fr/~moy/