Re: [PATCH v8 3/8] add line number and file name info to `config_set`
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Aug 6, 2014, 15:49 UTC
- Message-ID
- <53E24EA2.2030807@ramsay1.demon.co.uk>
- In-Reply-To
- <1407336792-16962-4-git-send-email-tanayabh@gmail.com>
On 06/08/14 15:53, Tanay Abhra wrote:
Show 22 quoted lines
> Store file name and line number for each key-value pair in the cache
> during parsing of the configuration files.
>
> Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
> ---
> cache.h | 5 +++++
> config.c | 16 ++++++++++++++--
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/cache.h b/cache.h
> index 7292aef..0b1bdfd 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -1383,6 +1383,11 @@ extern int git_config_get_bool_or_int(const char *key, int *is_bool, int *dest);
> extern int git_config_get_maybe_bool(const char *key, int *dest);
> extern int git_config_get_pathname(const char *key, const char **dest);
>
> +struct key_value_info {
> + const char *filename;
> + int linenr;
> +};
> +Hmm, why was this moved here? As far as I can tell, it is (still) not needed outside of config.c. What am I missing?
ATB, Ramsay Jones