git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/7] bisect: add the terms old/new

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 10, 2015, 21:03 UTC
Message-ID
<xmqqoakni8da.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1433953472-32572-4-git-send-email-antoine.delaite@ensimag.grenoble-inp.fr>
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:
Show 8 quoted lines
> Related discussions:
>
> 	- http://thread.gmane.org/gmane.comp.version-control.git/86063
> 		introduced bisect fix unfixed to find fix.
> 	- http://thread.gmane.org/gmane.comp.version-control.git/182398
> 		discussion around bisect yes/no or old/new.
> 	- http://thread.gmane.org/gmane.comp.version-control.git/199758
> 		last discussion and reviews
Hmph, recent reviews and discussions we had here do not count?

I do agree with Matthieu's review on the last round, which is still not quite addressed in this round. The current code only supports good/bad and this series merely adds another hardcoded pair old/new, which is disappointing, given that this is a very good opportunity to place an infrastructure to allow other pairs like unfixed/fixed building on top of the most generic old/new.

Previous: Antoine DelaiteNext: Louis-Alexandre Stuber
Message 8 of 9 in “bisect : correction of typo”
  1. 1/7 bisect : correction of typoAntoine Delaite, Jun 10, 2015
  2. 2/7 bisect: replace hardcoded "bad|good" by variablesAntoine Delaite, Jun 10, 2015
  3. Matthieu MoyJun 11, 2015
  4. 2/7 bisect: replace hardcoded "bad|good" by variablesAntoine Delaite, Jun 22, 2015
  5. Matthieu MoyJun 22, 2015
  6. 3/7 bisect: simplify the addition of new bisect termsAntoine Delaite, Jun 10, 2015
  7. 4/7 bisect: add the terms old/newAntoine Delaite, Jun 10, 2015
  8. Junio C HamanoJun 10, 2015
  9. Louis-Alexandre StuberJun 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.