git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/7] bisect: replace hardcoded "bad|good" by variables

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 22, 2015, 13:47 UTC
Message-ID
<vpqvbefc0sp.fsf@anie.imag.fr>
In-Reply-To
<134997869.703022.1434976943783.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:
Show 9 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote: 
>
>>Being an acceptable ref name is a constraint you have to check (Junio 
>>already mentionned check-ref-format). I think quoting variables makes 
>>sense too 
>
> I don't get how 'git check-ref-format' works exactly. It says it needs 
> at least one slash in the ref name. So it would not be good for bisect 
> terms.

At some point, refs/bisect/$good and refs/bisect/$bad-$sha1 will become refs, so you should check refs/bisect/$good and refs/bisect/$bad with check-ref-format (I think the -$sha1 suffix will be accepted by construction).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Antoine DelaiteNext: Antoine Delaite
Message 5 of 9 in “bisect : correction of typo”
  1. 1/7 bisect : correction of typoAntoine Delaite, Jun 10, 2015
  2. 2/7 bisect: replace hardcoded "bad|good" by variablesAntoine Delaite, Jun 10, 2015
  3. Matthieu MoyJun 11, 2015
  4. 2/7 bisect: replace hardcoded "bad|good" by variablesAntoine Delaite, Jun 22, 2015
  5. Matthieu MoyJun 22, 2015
  6. 3/7 bisect: simplify the addition of new bisect termsAntoine Delaite, Jun 10, 2015
  7. 4/7 bisect: add the terms old/newAntoine Delaite, Jun 10, 2015
  8. Junio C HamanoJun 10, 2015
  9. Louis-Alexandre StuberJun 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.