Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2016, 13:02 UTC
Message-ID: <xmqqoa6mdbu3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160626234251.GA21668@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I also wondered how we managed to miss such an obvious point in review
> of the original patch. Sadly, we _did_ notice it[1] but it looks like we
> never fixed the problem. That is even more disturbing.

Yes indeed.

I try to pay attention to "this is broken because..." comments in discussions to make a note in my copy of "What's cooking" report for a problematic topic, as that is where I work from when merging topics down, but apparently that procedure failed work in this case. There needs a stronger mechanism to stop a known-buggy patch from going thru, but I am not sure offhand what that should be.