git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 24, 2017, 18:13 UTC
Message-ID
<xmqqo9td9rui.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<87zicx1wig.fsf@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 13 quoted lines
> On Sat, Jun 24 2017, Junio C. Hamano jotted:
>
>> Is the far-in-the-future vision to make this the other way around?
>> That is, this being scaffolding, wildmatch_match() which is supposed
>> to be precompiled match actually uses wildmatch() as its underlying
>> engine, but when a viable compilation machinery is plugged in, the
>> wildmatch_match() that takes a precompiled pattern will call into
>> the machinery to execute the compiled pattern, and wildmatch() will
>> be reimplemented as "compile, call wildmatch_match() once and
>> discard" sequence?
>
> Exactly there would be no functional difference in the results, only
> fixed overhead.
OK, good!
Thanks.
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 6 of 7 in “wildmatch refactoring”
  1. 0/3 wildmatch refactoringÆvar Arnfjörð Bjarmason, Jun 22, 2017
  2. 1/3 wildmatch: remove unused wildopts parameterÆvar Arnfjörð Bjarmason, Jun 22, 2017
  3. 2/3 wildmatch: add interface for precompiling wildmatch() patternsÆvar Arnfjörð Bjarmason, Jun 22, 2017
  4. Junio C HamanoJun 24, 2017
  5. Ævar Arnfjörð BjarmasonJun 24, 2017
  6. Junio C HamanoJun 24, 2017
  7. 3/3 wildmatch: make use of the interface for precompiling wildmatch() patternsÆvar Arnfjörð Bjarmason, Jun 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.