git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] wildmatch refactoring

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 22, 2017, 21:38 UTC
Message-ID
<20170622213810.14785-1-avarab@gmail.com>

The first patch here should be applied, but 2 & 3 trail along as RFCs to show where this is going.

The RFC patches work, but I'm sure there'll be critiques of the interface / other suggestions, so they're being sent as RFC so Junio doesn't need to worry about picking them up / tracking them.

This is prep work for a local series of mine which compiles the wildmatch pattern into JIT-ed PCRE v2 patterns. That may or may not end up going anywhere, but as 2/3 notes just making these changes makes it easier to optimize wildmatch() further down the road.

Ævar Arnfjörð Bjarmason (3):
  wildmatch: remove unused wildopts parameter
  wildmatch: add interface for precompiling wildmatch() patterns
  wildmatch: make use of the interface for precompiling wildmatch()
    patterns
 apply.c                   |  2 +-
 builtin/describe.c        |  4 ++--
 builtin/ls-remote.c       |  2 +-
 builtin/name-rev.c        |  6 +++++-
 builtin/reflog.c          |  2 +-
 builtin/replace.c         |  7 ++++---
 builtin/show-branch.c     |  2 +-
 config.c                  |  8 ++++++--
 diffcore-order.c          |  2 +-
 dir.c                     | 20 +++++++++++++++-----
 ref-filter.c              |  4 ++--
 refs.c                    |  7 ++++---
 revision.c                |  2 +-
 t/helper/test-wildmatch.c |  6 +++---
 wildmatch.c               | 23 +++++++++++++++++++++--
 wildmatch.h               | 13 +++++++++----
 16 files changed, 77 insertions(+), 33 deletions(-)
-- 
2.13.1.611.g7e3b11ae1
Next: Ævar Arnfjörð Bjarmason
Message 1 of 7 in “wildmatch refactoring”
  1. 0/3 wildmatch refactoringÆvar Arnfjörð Bjarmason, Jun 22, 2017
  2. 1/3 wildmatch: remove unused wildopts parameterÆvar Arnfjörð Bjarmason, Jun 22, 2017
  3. 2/3 wildmatch: add interface for precompiling wildmatch() patternsÆvar Arnfjörð Bjarmason, Jun 22, 2017
  4. Junio C HamanoJun 24, 2017
  5. Ævar Arnfjörð BjarmasonJun 24, 2017
  6. Junio C HamanoJun 24, 2017
  7. 3/3 wildmatch: make use of the interface for precompiling wildmatch() patternsÆvar Arnfjörð Bjarmason, Jun 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.