From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 24 Jun 2017 18:13:25 GMT
Subject: Re: [RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns
Message-ID: <xmqqo9td9rui.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <87zicx1wig.fsf@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Sat, Jun 24 2017, Junio C. Hamano jotted:
>
>> Is the far-in-the-future vision to make this the other way around?
>> That is, this being scaffolding, wildmatch_match() which is supposed
>> to be precompiled match actually uses wildmatch() as its underlying
>> engine, but when a viable compilation machinery is plugged in, the
>> wildmatch_match() that takes a precompiled pattern will call into
>> the machinery to execute the compiled pattern, and wildmatch() will
>> be reimplemented as "compile, call wildmatch_match() once and
>> discard" sequence?
>
> Exactly there would be no functional difference in the results, only
> fixed overhead.

OK, good!

Thanks.