Re: [PATCH v5 6/6] ref-filter.c: parse trailers arguments with %(contents) atom

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 2, 2017, 04:26 UTC
Message-ID: <xmqqo9pqp442.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171002003304.77514-6-me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> A caveat: trailers_atom_parser expects NULL when no arguments are given
> (see: `parse_ref_filter_atom`). This is because string_list_split (given
> a maxsplit of -1) returns a 1-ary string_list* containing the given
> string if the delimiter could not be found using `strchr`.

OK. That's unfortunate, but the solution here is far cleaner and simpler than fixing string-list-split. Thanks for an updated explanation here.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.