Re: [PATCH v5 6/6] ref-filter.c: parse trailers arguments with %(contents) atom
- From
Jeff King <peff@peff.net>
- Date
- Oct 2, 2017, 05:14 UTC
- Message-ID
- <20171002051417.hrdbxowk7eoczpcd@sigill.intra.peff.net>
- In-Reply-To
- <20171002051216.GB5566@D-10-157-251-166.dhcp4.washington.edu>
On Sun, Oct 01, 2017 at 10:12:16PM -0700, Taylor Blau wrote:
Show 19 quoted lines
> > Doh, that string_list behavior is what I was missing in my earlier > > comments. I agree this is probably the best way of doing it. I'm tempted > > to say that parse_ref_filter_atom() should do a similar thing. Right now > > we've got: > > > > $ git for-each-ref --format='%(refname)' | wc > > 2206 2206 79929 > > $ git for-each-ref --format='%(refname:short)' | wc > > 2206 2206 53622 > > $ git for-each-ref --format='%(refname:)' | wc > > fatal: unrecognized %(refname:) argument: > > 0 0 0 > > > > which seems a bit unfriendly. As we're on v6 here, I don't want to > > suggest it as part of this series. But maybe a #leftoverbits candidate, > > if others agree it's a good direction. > > I think #leftoverbits is fine here, but I think addressing this before > 2.15 is reasonable. I can take a look at this in a future patch series.
I think it would be to just do it as a standalone patch immediately. I just didn't want to hold your series hostage to a potential disagreement.
-Peff