Re: [PATCH 4/5] ref-filter.c: use trailer_opts to format trailers

From: Jeff King <peff@peff.net>
Date: Oct 2, 2017, 05:05 UTC
Message-ID: <20171002050507.i27l2iulfbskmnpx@sigill.intra.peff.net>
In-Reply-To: <xmqqbmlrutsm.fsf@gitster.mtv.corp.google.com>

On Sun, Oct 01, 2017 at 06:00:25PM +0900, Junio C Hamano wrote:

Show 18 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
> 
> > diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
> > index 2a9fcf713..2bd0c5da7 100755
> > --- a/t/t6300-for-each-ref.sh
> > +++ b/t/t6300-for-each-ref.sh
> > @@ -597,6 +597,9 @@ Acked-by: A U Thor
> >    <author@example.com>
> >  EOF
> >  
> > +unfold () {
> > +	perl -0pe 's/\n\s+/ /'
> > +}
> 
> For the purpose of the current shape of the test, the above might be
> sufficient, but the lack of "/g" at the end means that the script
> will happily stop after unfolding just one line, which probably is
> not what you intended.

This is indirectly my fault, since this was copied from my t4205 version. It might be worth fixing while we're thinking about it, as it's a potential trap for future changes.

-Peff