Re: [PATCH 1/1] Introduce "precious" file concept

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2019, 22:39 UTC
Message-ID: <xmqqo976ultb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8B15hORnaOdYW8TNE3Gniv9NBJopyLYmHR5iF0U3beq6g@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> There is a trade off somewhere. "new user first" should not come at
> the cost for more experienced users.

Probably.  Nobody will stay being newbie forever.

Show 5 quoted lines

> Making "git checkout/merge" abort while it's working before breaks
> scripts. And requiring to mark trashable files manually duplicates a
> lot of ignore patterns. Have a look at any .gitignore file, the
> majority of them is for discardable files because "ignored" class was
> created with those in mind (*.o and friends).

Very true. That is why we were OK for so long with "ignored" that means "ignored and expendable". We know in some situations we want "ignored but precious", and that is why we are discussing this topic.

Show 6 quoted lines

> So now you would need to
> add more or less the same set of ignore rules in .gitattributes to
> mark them trashable, and gitignore/gitattributes rules are not exactly
> compatible, you can't just blindly copy them over. Every time you add
> one more .gitignore rule, there's a good chance you need to add a
> similar rule for trashable attribute.

I am not sure why you would even need to _duplicate_.

Are you saying for each and every rule that specify "ignored and expendable" in .gitignore there always will be "ignored but precious" exception that match the pattern? Given that we have been OK for so long without even needing "precious", I find it somewhat unrealistic to assume so.